Fix post deployment hook for /etc/hosts in multi-stack #985
+3
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
no need for test project, multi-cell tripleo code is still noop (only 1 cell is deployed in adoption CI yet) |
Add /etc/hosts entries for all cells' nodes on internal_api network as well. Enable rabbitmq connections from superconductor and scheduler via transport URLs defined for other cells'. NOTE: tripleo_stack_name only used in start/end markers by the tripleo_hosts_entries role. Use a non-conflicting "stack" name for markers to append to hosts entries created for the overcloud stack, and stacks created for additional cells. Signed-off-by: Bohdan Dobrelia <[email protected]>
bogdando
force-pushed
the
tripleo_multi_stack
branch
from
295084a to
76ae8c5
Compare
|
/approve |
slagle
approved these changes
Jan 9, 2025
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: bogdando, fao89, slagle The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
Happy New Year, folks! Can we have this merged, please? @fao89 @jistr @stuggi @olliewalsh |
its already in merge pool |
openshift-merge-bot
bot
merged commit b989130
into
openstack-k8s-operators:main
5 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add /etc/hosts entries for all cells' nodes on internal_api network as well. Enable rabbitmq connections from superconductor and scheduler via transport URLs defined for other cells'.
NOTE: tripleo_stack_name only used in start/end markers by the tripleo_hosts_entries role. Use a non-conflicting "stack" name for markers to append to hosts entries created for the overcloud stack, and stacks created for additional cells.
Required-by: openstack-k8s-operators/data-plane-adoption#746